Updated to .NET 5 wherever possible #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update NuGet packages in tests Fixed some warnings
|
This PR is ready for review. |
cafour
reviewed
May 21, 2021
...rk.Api.Swashbuckle.AspNetCore.Tests/DotVVM.Framework.Api.Swashbuckle.AspNetCore.Tests.csproj
Outdated
Show resolved
Hide resolved
|
Fixed all issues. Should be good to go. @cafstep @tomasherceg |
quigamdev
approved these changes
May 22, 2021
exyi
approved these changes
May 22, 2021
| CustomersDataSet.SetSortExpression("BirthDate"); | ||
| if (CustomersDataSet.SortingOptions.SortExpression == "BirthDate") | ||
| { | ||
| CustomersDataSet.SortingOptions.SortDescending = !CustomersDataSet.SortingOptions.SortDescending; |
There was a problem hiding this comment.
Suggested change
| CustomersDataSet.SortingOptions.SortDescending = !CustomersDataSet.SortingOptions.SortDescending; | |
| CustomersDataSet.SortingOptions.SortDescending ^= true; |
;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: this PR is based on #872 (to prevent possible conflicts). Do not review & merge before merging new CLI first.
Some projects were targetting .NET Core 2.0 or 3.0 which are out of support.
I've updated:
Versions of the framework itself remain as they are.
I've also fixed some warnings also, but we have still quite a lot of them (mostly related to nullable reference types).